Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(minor-rewards): msg and state separation #761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

fish-sammy
Copy link
Collaborator

Description

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Convention Checklist

  • Each contract should have a client mod for others to interact with it.
  • Derive macros
  • The state mod and msg mod should use separate data structures so that internal state changes do not break the contract interface. Check out the interchain-token-service for reference.
    • msg.rs should never use any type from the state.rs
    • Shared types must be defined in a separate exported mod. If those types have already been defined somewhere else, then they should get re-exported in the exported mod

Steps to Test

Expected Behaviour

Notes

@fish-sammy fish-sammy requested a review from a team as a code owner February 12, 2025 18:08
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 89.65517% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.35%. Comparing base (1a8a4cc) to head (4aeda46).

Files with missing lines Patch % Lines
contracts/rewards/src/contract.rs 75.67% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
- Coverage   93.36%   93.35%   -0.02%     
==========================================
  Files         225      225              
  Lines       36359    36414      +55     
==========================================
+ Hits        33947    33993      +46     
- Misses       2412     2421       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant