refactor(minor-interchain-token-service): change max uint to max bits #760
+87
−143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 93.36% 93.35% -0.01%
==========================================
Files 225 225
Lines 36359 36366 +7
==========================================
+ Hits 33947 33951 +4
- Misses 2412 2415 +3 ☔ View full report in Codecov by Sentry. |
|
What's the reason for making this change? Easier to configure? |
fish-sammy
reviewed
Feb 13, 2025
| Ok(res) => res.gt(&Uint256::zero()), | ||
| // this overflow error occurs when trying to shift 256 bits or more. | ||
| // But this can only happen if max_bits is >= 256, and amount itself is only 256 bits. | ||
| // So in this can, amount cannot possibly overflow the max uint of the target chain |
There was a problem hiding this comment.
Suggested change
| // So in this can, amount cannot possibly overflow the max uint of the target chain | |
| // So in this case, amount cannot possibly overflow the max uint of the target chain |
fish-sammy
reviewed
Feb 13, 2025
| @@ -60,8 +59,8 @@ pub struct ChainConfig { | |||
|
|
|||
| #[cw_serde] | |||
| pub struct TruncationConfig { | |||
| pub max_uint: nonempty::Uint256, // The maximum uint value that is supported by the chain's token standard | |||
| pub max_decimals_when_truncating: u8, // The maximum number of decimals that is preserved when deploying from a chain with a larger max_uint | |||
| pub max_uint_bits: u32, // The maximum number of bits used by the chain to represent unsigned integers | |||
There was a problem hiding this comment.
Do we have a nonempty::u32? zero wouldn't make sense here.
fish-sammy
reviewed
Feb 13, 2025
| @@ -41,15 +41,15 @@ pub struct ChainConfig { | |||
|
|
|||
| #[cw_serde] | |||
| pub struct TruncationConfig { | |||
| pub max_uint: nonempty::Uint256, // The maximum uint value that is supported by the chain's token standard | |||
| pub max_decimals_when_truncating: u8, // The maximum number of decimals that is preserved when deploying from a chain with a larger max_uint | |||
| pub max_uint_bits: u32, // The maximum number of bits used to represent unsigned integer values that is supported by the chain's token standard | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todos
need to migrate the existing chain configs
https://axelarnetwork.atlassian.net/browse/AXE-7486