Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update dockerfile to build only ampd #759

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eguajardo
Copy link
Contributor

@eguajardo eguajardo commented Feb 11, 2025

Reduces docker build time by about 4 minutes by only building ampd instead of the whole workspace. Also copies over the whole workspace so there is no need to update every time there is a change in the directory structure.

It seems that the image weights the same (131mb) as the image created before this changes

@eguajardo eguajardo requested review from a team as code owners February 11, 2025 03:15
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.36%. Comparing base (1a8a4cc) to head (5df6a6a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #759   +/-   ##
=======================================
  Coverage   93.36%   93.36%           
=======================================
  Files         225      225           
  Lines       36359    36359           
=======================================
  Hits        33947    33947           
  Misses       2412     2412           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fish-sammy fish-sammy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of building ampd only and excluding unrelated packages and contracts. However, the multi-stage build of ampd itself shouldn't be removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants