-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(minor-interchain-token-service): all chains with optional filter query message #754
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 93.36% 93.37%
=======================================
Files 225 225
Lines 36359 36422 +63
=======================================
+ Hits 33947 34009 +62
- Misses 2412 2413 +1 ☔ View full report in Codecov by Sentry. |
ItsChains { | ||
filter: Option<ChainFilter>, | ||
start_after: Option<ChainNameRaw>, | ||
limit: Option<u32>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
limit: Option<u32>, | |
#[serde(default = "default_pagination_limit"] | |
limit: u32, |
with
const fn default_pagination_limit() -> u32{
DEFAULT_LIMIT
}
this makes it clearer that we never do an unbounded search
Description
AXE-7369
Todos
Convention Checklist
exported
mod. If those types have already been defined somewhere else, then they should get re-exported in theexported
modSteps to Test
Expected Behaviour
Notes