Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(minor-interchain-token-service): all chains with optional filter query message #754

Open
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

maancham
Copy link
Contributor

@maancham maancham commented Feb 5, 2025

Description

AXE-7369

Todos

  • Unit tests
  • Manual tests
  • Documentation
  • Connect epics/issues

Convention Checklist

  • Each contract should have a client mod for others to interact with it.
  • Derive macros
  • The state mod and msg mod should use separate data structures so that internal state changes do not break the contract interface. Check out the interchain-token-service for reference.
    • msg.rs should never use any type from the state.rs
    • Shared types must be defined in a separate exported mod. If those types have already been defined somewhere else, then they should get re-exported in the exported mod

Steps to Test

Expected Behaviour

Notes

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.37%. Comparing base (1a8a4cc) to head (252d036).

Files with missing lines Patch % Lines
...cts/interchain-token-service/src/contract/query.rs 97.67% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   93.36%   93.37%           
=======================================
  Files         225      225           
  Lines       36359    36422   +63     
=======================================
+ Hits        33947    34009   +62     
- Misses       2412     2413    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maancham maancham marked this pull request as ready for review February 6, 2025 16:00
@maancham maancham requested a review from a team as a code owner February 6, 2025 16:00
contracts/interchain-token-service/src/contract/query.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/contract.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/contract/query.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/contract/query.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/state.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/state.rs Outdated Show resolved Hide resolved
contracts/interchain-token-service/src/state.rs Outdated Show resolved Hide resolved
@maancham maancham requested a review from fish-sammy February 11, 2025 21:13
ItsChains {
filter: Option<ChainFilter>,
start_after: Option<ChainNameRaw>,
limit: Option<u32>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
limit: Option<u32>,
#[serde(default = "default_pagination_limit"]
limit: u32,

with

const fn default_pagination_limit() -> u32{
    DEFAULT_LIMIT
}

this makes it clearer that we never do an unbounded search

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants