feat: add solana ampd implementation #744

eloylp · 2025-01-13T13:11:50Z

At Eiger, we are implementing the integration between Axelar and Solana.

This PR introduces the necessary logic for the ampd component, including:

The Solana message verifier handler.
The Solana verifier set verifier handler.
The logic required to validate Solana addresses.

Both verifier components share the same Solana transaction fetch and log parsing logic, which facilitates identifying event sequences within Solana programs execution outputs.

Todos

Unit tests
Manual tests (pending - waiting Axelar contract deployment approval)
Documentation
Connect epics/issues

Steps to Test

Configure ampd with an updated ampd.toml file, pointing to a local tofnd setup.
tofnd must be up and running.
Compile and start the ampd daemon.
Execute the memo program flow, which sends a message from Evm to Solana and viceversa. Scripts can be found at solana-axelar-scripts

Expected Behaviour

It should forward GMP messages from one chain to the another, passing them through the axelar devnet network.

Other Notes

Manual testing is missing because we are waiting for Axelar contract approval.

* Add Solana account parsing tools.

… functions.

* Add solana verification functionality * Add unit tests to Solana message verifier * Refactor * Solana msg verifier reshape (#4) * remove comment * Use Solana types from Solana crates We were using hand crafted Solana types for interacting with RPC. * refactor: make clippy happy * Add some traces to Solana msg verifier * Remove outdated todos * refactor: re-use already calculated variable * Clarify test code usage * Solana msg verifier, try till one program log matches gw event * Add note to axelar to review when in PR * fail if tx_id is not found in signatures * Always fail on chain at handler level * Handle errors in case a tx cannot be found (finish the handler) * Remove commented code * Use original type from solana-axelar repo * Ensure that we verify sender address in sol msg verifier * Do not panic on PartialEq * refactor: clippy * remove no longer used code * Add more tests definition to solana msg verify iteration logic --------- Co-authored-by: eloylp <[email protected]>

…et-verifier

Were only intended during development to understand the API.

Co-authored-by: tilacog <[email protected]>

Signed-off-by: Guilherme Felipe da Silva <[email protected]>

It will be managed later. This prepares this branch for merge with upstream.

bugfix on event parsing

cjcobb23 · 2025-01-29T18:15:41Z

ampd/src/handlers/solana_verify_msg.rs

+        let poll_id_str: String = poll_id.into();
+        let source_chain_str: String = source_chain.into();


might be cleaner to just do this inline

Fixed at 3a5d750

cjcobb23 · 2025-01-29T18:15:52Z

ampd/src/handlers/solana_verify_msg.rs

+        };
+        if !participants.contains(&self.verifier) {


Suggested change

};

if !participants.contains(&self.verifier) {

};

if !participants.contains(&self.verifier) {

Fixed at f7fd35a

cjcobb23 · 2025-01-30T16:56:54Z

ampd/src/solana/msg_verifier.rs

+                GatewayEvent::CallContract(event) => (
+                    &event.sender_key,
+                    &event.payload_hash,
+                    &event.destination_chain,
+                    &event.destination_contract_address,
+                ),
+                GatewayEvent::CallContractOffchainData(event) => (
+                    &event.sender_key,
+                    &event.payload_hash,
+                    &event.destination_chain,
+                    &event.destination_contract_address,
+                ),


might want to add some comments here about why there are two events

Fixed at 028f434

cjcobb23 · 2025-01-30T17:16:50Z

ampd/src/solana/mod.rs

+        }
+    };
+
+    // pare the events


Suggested change

// pare the events

// compare the events

Fixed at 4b3c1fb

cjcobb23 · 2025-01-30T17:22:05Z

ampd/src/solana/mod.rs

+where
+    F: Fn(&GatewayEvent) -> bool,
+{
+    // the event idx cannot be larger than usize


why? also we might want to fail earlier in this case, there's no point to even make the RPC call

cjcobb23 · 2025-01-30T18:00:54Z

ampd/src/handlers/solana_verify_msg.rs

+        if !participants.contains(&self.verifier) {
+            return Ok(vec![]);
+        }
+


should check the source chain

I am assuming ™️ (correct me if am wrong) each chain deploys it's own voting verifier cosmwasm contract. If that's true, wouldn't this check be enough ?

We don't see the source chain check in any implementation apart from evm

cjcobb23 · 2025-01-30T18:01:15Z

ampd/src/handlers/solana_verify_verifier_set.rs

+        if !participants.contains(&self.verifier) {
+            return Ok(vec![]);
+        }
+


should check the source chain

Let's follow conversation here: #744 (comment)

cjcobb23 · 2025-01-30T18:21:26Z

ampd/src/stellar/verifier.rs

@@ -69,7 +69,7 @@ impl PartialEq<ContractEventBody> for VerifierSetConfirmation {
    }
 }

-pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {
+pub fn  verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {


Suggested change

pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {

pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {

fixed at f7fd35a

cjcobb23 · 2025-01-30T18:22:50Z

packages/axelar-wasm-std/src/address.rs

+        AddressFormat::Base58Solana => {
+            const SOLANA_PUBKEY_LEN: usize = 32;
+
+            let pubkey_vec = bs58::decode(address)
+                .into_vec()
+                .change_context(Error::InvalidAddress(address.to_string()))?;
+            if pubkey_vec.len() != SOLANA_PUBKEY_LEN {
+                bail!(Error::InvalidAddress(address.to_string()))
+            }
+        }


where is this being used?

It shouldn't be part of this branch (unrelated changes), we removed it at 00ed5e3

cjcobb23 · 2025-01-30T18:24:31Z

ampd/README.md

+cosmwasm_contract = "axelar1qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqecnww6"
+chain_name = "solana"
+chain_rpc_url = "https://api.devnet.solana.com"
+max_tx_cache_entries = 6


Is this correct? Where is this handled?

This was part of a previous, already removed implementation. Fixed at a28db9d by removing it as well.

chore: feedback react

eloylp and others added 30 commits February 6, 2024 20:44

Add initial POC scaffolding of Solana workerset verifier

af465bb

refactor, remove unnecessary String indirection

28a3cac

Add some todos

ee49734

* Add auth-weighted as dependency (needed for types)

83f97cc

* Add Solana account parsing tools.

Expose binary serialisation for U256

7d60690

Propagate Clone,Copy traits to wrapper type

645e491

Add needed solana RPC methods for workerset verification logic

f5f9212

Complete the Solana working set verification logic, core verification…

ca7d699

… functions.

Solana code refactors (clippy)

6a2dbb9

Add unhappy path tests for Solana workerset verification logic

862a823

Complete comment

c818eaf

Formatting

1c47e32

refactor: move workerset verifier logic to its own file

50c07d1

Merge remote-tracking branch 'origin/solana' into add-solana-worker-s…

e96960b

…et-verifier

refactor: Move solana msg verification helpers to its own file.

914f52c

Ignore exploratory tests

1358675

Replace raw rpc client with solana non blocking RPC client

30b3b73

Discern among not found results and RPC errors

f654716

Fix clippy

259af2e

Do not panic when parsing solana tx signatures

fd81c80

Ensure we log errors while fetching transactions

dd0674d

remove non used tests

33782a5

Were only intended during development to understand the API.

replace unwrap by let-else syntax

3c12598

Co-authored-by: tilacog <[email protected]>

Use let if syntax

357bc39

Co-authored-by: tilacog <[email protected]>

Properly log error message

db24220

Use let if syntax

42bee6d

Co-authored-by: tilacog <[email protected]>

Remove redundant comparison function

4668594

Co-authored-by: tilacog <[email protected]>

clarify log message

c9acc10

Co-authored-by: tilacog <[email protected]>

FIx test and compilation errors

e3c23c2

roberts-pumpurs and others added 13 commits November 30, 2024 17:01

test: tests for verify verifier set handler

1490a22

chore: linter cleanup

40790eb

refactor: update solana gateway dep

421baa3

chore(solana): update solana-axelar dependency

b89b134

Signed-off-by: Guilherme Felipe da Silva <[email protected]>

feat(solana): add support for CallContract with offchain data

20cd40e

Signed-off-by: Guilherme Felipe da Silva <[email protected]>

Merge remote-tracking branch 'origin/main' into solana

58cdb28

feat: update axelar solana deps (#53)

5428556

feat: restore multisig prover contract (#54)

31225b4

It will be managed later. This prepares this branch for merge with upstream.

fix: import order

1a6b3a8

fix: be consistent in test fixtures

cc168e5

fix: function name

66504ea

fix: be consistent in tes fixture rpc_url param

6499d82

fix: make clippy happy

fb6bff4

eloylp requested a review from a team as a code owner January 13, 2025 13:11

feat: update axelar-solana deps

bfa70ed

bugfix on event parsing

cjcobb23 reviewed Jan 30, 2025

View reviewed changes

eloylp added 8 commits February 1, 2025 20:12

fix: reformat code

d0d94ae

refactor: inline string conversion

3a5d750

refactor: remove whitespace

f7fd35a

fix: remove outdated docs and test fixtrure

a28db9d

docs: add comments explaining different gateway call contract events.

028f434

fix: typo

4b3c1fb

feat: simplify event checking

131aba1

fix: remove non ampd related changes

00ed5e3

eloylp mentioned this pull request Feb 5, 2025

chore: feedback react eigerco/axelar-amplifier#59

Merged

eloylp added 5 commits February 7, 2025 11:44

feat: Optimise log parsing logic

fb5d493

refactor: remove unnecessary else branch

92dd513

Merge pull request #59 from eigerco/feedback-react

865a924

chore: feedback react

Merge remote-tracking branch 'origin/main' into solana

1dec8d3

Merge remote-tracking branch 'origin/main' into solana

00c7f11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add solana ampd implementation #744

feat: add solana ampd implementation #744

eloylp commented Jan 13, 2025

cjcobb23 Jan 29, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 29, 2025

eloylp Feb 8, 2025 •

edited

Loading

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025 •

edited

Loading

cjcobb23 Jan 30, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025

cjcobb23 Jan 30, 2025

eloylp Feb 8, 2025 •

edited

Loading

		let poll_id_str: String = poll_id.into();
		let source_chain_str: String = source_chain.into();

	pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {
	pub fn verify_message(gateway_address: &ScAddress, tx_receipt: &TxResponse, msg: &Message) -> Vote {

feat: add solana ampd implementation #744

Are you sure you want to change the base?

feat: add solana ampd implementation #744

Conversation

eloylp commented Jan 13, 2025

Todos

Steps to Test

Expected Behaviour

Other Notes

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eloylp Feb 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eloylp Feb 8, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eloylp Feb 8, 2025 • edited Loading

Choose a reason for hiding this comment

eloylp Feb 8, 2025 •

edited

Loading

eloylp Feb 8, 2025 •

edited

Loading

eloylp Feb 8, 2025 •

edited

Loading