refactor(minor-voting-verifier): integrate the voting-verifier with the into-event macro #743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #743 +/- ##
========================================
Coverage 93.36% 93.36%
========================================
Files 225 225
Lines 36359 36253 -106
========================================
- Hits 33947 33849 -98
+ Misses 2412 2404 -8 ☔ View full report in Codecov by Sentry. |
…he into-event macro
fish-sammy
force-pushed
the
refactor/integrate-into-event-with-voting-verifier
branch
from
ee375c1 to
b1a9069
Compare
fish-sammy
changed the title
cgorenflo
reviewed
Feb 10, 2025
| @@ -635,6 +494,7 @@ mod test { | |||
| None, | |||
| ], | |||
| } | |||
| .non_generic() | |||
| .into(); | |||
|
|
|||
| goldie::assert_json!(json!({ | |||
There was a problem hiding this comment.
can you make sure that we're exhaustively testing all events? So the test should break if we add a new event variant without adding it here
There was a problem hiding this comment.
Not sure how you can do that, but it's not necessary since this test is there to make sure the differences in the JSON before and after using the macro are OK. With new events, do we need them to be added here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Todos
Steps to Test
Expected Behaviour
Other Notes