Skip to content

Fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Fix #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cd5474f
Fix
axeh Apr 7, 2022
8c52f42
Fix
axeh Apr 7, 2022
fc0fda7
Fix
axeh Apr 7, 2022
b8a582d
Naming
axeh Apr 7, 2022
6787c10
Naming
axeh Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions MSBuildLaunchPad/ParserFactory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ public static class ParserFactory
public static IParser Parse(string fileName)
{
string extension = Path.GetExtension(fileName);
var n = extension.Length;
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use a more descriptive name for naming the variable. How about extensionLenght?


if (extension == ".sln")
{
return new SolutionParser(fileName);
Expand Down