Conversation
- Implemented `searchEvents` service to search for events by name or SKU. - Added search functionality to the "Robotevents.com link" section. - Added a dropdown to display search results. - Users can now search for events by name or SKU and load them directly. - Updated footer to hide copyright text on mobile devices (`hidden sm:block`). Co-authored-by: axcdeng <121896294+axcdeng@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Summary of ChangesHello @axcdeng, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Viewer page by introducing robust event search capabilities, allowing users to find events more flexibly. Additionally, it refines the mobile user experience by adjusting the visibility of the page footer, ensuring a cleaner interface on smaller devices. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully implements event searching and a responsive footer. The code is well-structured, and the new search functionality is a great addition. I've provided a couple of suggestions to enhance the user experience and robustness of the new search feature. One suggestion is to improve the search dropdown's usability by closing it on outside clicks and adding ARIA attributes for better accessibility. The other suggestion fixes a minor bug in how event locations are displayed in the search results.
| <div className="font-bold text-white text-sm line-clamp-1">{evt.name}</div> | ||
| <div className="flex justify-between items-center mt-1"> | ||
| <span className="text-xs text-gray-400"> | ||
| {evt.location?.city}{evt.location?.region ? `, ${evt.location.region}` : ''} |
There was a problem hiding this comment.
The current logic for displaying the location can result in a leading comma if evt.location.city is missing but evt.location.region is present (e.g., , California). A more robust way to handle this is to build an array of location parts and join them.
| {evt.location?.city}{evt.location?.region ? `, ${evt.location.region}` : ''} | |
| {[evt.location?.city, evt.location?.region].filter(Boolean).join(', ')} |
|
@google-labs-jules the search should instantly search, you can first request all the events of this season. Also, the searhc results are confined to the Div and barely show anything, making it unusable. Also, prioritize name searching and prioritize events returning level of Signature. Use curl to understand the api request and how to see all events as there is page pagination. |
I've addressed your feedback:
|
- Implemented debounced instant search in Viewer.jsx. - Fixed UI issue where dropdown was cut off by removing overflow-hidden from parent. - Updated sorting logic in searchEvents to prioritize Signature events, exact name matches, and date. Co-authored-by: axcdeng <121896294+axcdeng@users.noreply.github.com>
|
@google-labs-jules the search is a bit slow and the search does not work at all. i see all the results as like 2013 and 1999, but it should all be from the current season. ENSURE that the api calls work using curl on your device with the env api key. it should be the latest season 2025-2026. prioritize name searching. also, add a label to know if it is V5 or IQ |
Co-authored-by: axcdeng <121896294+axcdeng@users.noreply.github.com>
This PR implements event searching functionality in the Viewer page.
Changes:
Event Search:
src/services/robotevents.jsto addsearchEventsfunction.src/pages/Viewer.jsxto handle search input.Footer Update:
hidden sm:blockto the footer insrc/pages/Viewer.jsxto hide it on mobile devices as requested.Verification:
npm run build.PR created automatically by Jules for task 6699342773470703159 started by @axcdeng