Skip to content

[Do-Not-Merge] Ignore sagemaker-uploading #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Do-Not-Merge] Ignore sagemaker-uploading #470

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
155d8c8
ignore sagemaker-uploading
NihalHarish Mar 23, 2021
b169ae1
add special version tag
NihalHarish Mar 23, 2021
3ca5f91
semver versioning
NihalHarish Mar 23, 2021
2897643
Merge branch 'master' into me_binary_with_fix
ndodda-amazon Mar 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion smdebug/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "1.0.8"
__version__ = "1.0.8b"
Copy link
Contributor

@ndodda-amazon ndodda-amazon Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

1 change: 1 addition & 0 deletions smdebug/core/state_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ def _get_checkpoint_files_in_dir(self, cp_dir):
file != METADATA_FILENAME
and file != METADATA_FILENAME_S3_UPLOADED
and "sagemaker-uploaded" not in file
and "sagemaker-uploading" not in file
Copy link
Contributor

@ndodda-amazon ndodda-amazon Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This won't scale well. Can we keep track of a list of files not to append and then do something like:

if all([metadata_file not in file for metadata_file in metadata_files])

):
checkpoint_files.append(os.path.join(child, file))
return sorted(checkpoint_files)
Expand Down