-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make mypy
checks opt-out instead of opt-in, fix several type issues
#3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todos:
|
lostella
added
the
BREAKING
This is a breaking change (one of pr required labels)
label
Oct 24, 2023
shchur
reviewed
Oct 25, 2023
lostella
changed the title
Fix type checking issues in
Make Oct 25, 2023
gluonts.torch
mypy
checks opt-out instead of opt-in, fix several type issues
lostella
added
bug fix
(one of pr required labels)
enhancement
New feature or request
and removed
bug fix
(one of pr required labels)
labels
Oct 25, 2023
jaheba
previously approved these changes
Oct 26, 2023
jaheba
approved these changes
Oct 26, 2023
lostella
added
the
pending v0.14.x backport
This contains a fix to be backported to the v0.14.x branch
label
Oct 26, 2023
ddelange
added a commit
to ddelange/gluonts
that referenced
this pull request
Oct 26, 2023
* 'dev' of https://github.com/awslabs/gluonts: Make `mypy` checks opt-out instead of opt-in, fix several type issues (awslabs#3027)
lostella
added a commit
to lostella/gluonts
that referenced
this pull request
Oct 27, 2023
…awslabs#3027) Co-authored-by: Oleksandr Shchur <[email protected]>
lostella
added a commit
that referenced
this pull request
Oct 27, 2023
* Fix WaveNet inputs (#3022) * Fix version range for lightning (#3023) * Allow VCS install using GLUONTS_FALLBACK_VERSION (#3028) * Make `mypy` checks opt-out instead of opt-in, fix several type issues (#3027) Co-authored-by: Oleksandr Shchur <[email protected]> * No API docs for nursery. (#3030) * Fix: #3030. (#3031) * Add support for Pydantic v1 and v2. (#3026) --------- Co-authored-by: Oleksandr Shchur <[email protected]> Co-authored-by: ddelange <[email protected]> Co-authored-by: Jasper <[email protected]>
lostella
removed
the
pending v0.14.x backport
This contains a fix to be backported to the v0.14.x branch
label
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
.typesafe
files, add a.typeunsafe
file togluonts.nursery
to opt it outgluonts.torch.distributions
togluonts.torch.model.mqf2
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup