Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Exposes a sync init for client configs #957

Merged
merged 4 commits into from
Apr 19, 2023
Merged

fix!: Exposes a sync init for client configs #957

merged 4 commits into from
Apr 19, 2023

Conversation

epau
Copy link
Contributor

@epau epau commented Apr 13, 2023

This PR enables creating a client and client configuration synchronously.

  • exposes sync inits
  • cleans up initializers to reduce duplicative logic
  • moves credentials providers to types to better separate concerns and exposes a simpler API
  • removes caching of file based config as it is no longer needed. a file based config will be created once during client configuration initialization.

Issue #

#958

Description of changes

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@epau epau requested a review from jbelkins April 13, 2023 18:50
@epau epau marked this pull request as ready for review April 13, 2023 18:51
@epau epau force-pushed the epau/poc/sync-init branch from 31f0669 to a1a1373 Compare April 17, 2023 18:29
@epau epau force-pushed the epau/poc/sync-init branch from d26d9fc to b4ff2b1 Compare April 18, 2023 21:52
@epau epau merged commit f9be124 into main Apr 19, 2023
@epau epau deleted the epau/poc/sync-init branch April 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants