Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make LogAgent conform to Sendable #1908

Merged
merged 3 commits into from
Mar 20, 2025

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Mar 19, 2025

Companion PR: smithy-lang/smithy-swift#917

Issue #

N/A

Description of changes

  • Makes the test logger implementations with @unchecked Sendable; they contain mutable string array that stores logged messages for validating test results. Since tests don't need concurrency safety, just marked as unchecked.

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@sichanyoo sichanyoo changed the title PR for CI purposes chore: Make LogAgent conform to Sendable Mar 19, 2025
@sichanyoo sichanyoo merged commit 99f0708 into main Mar 20, 2025
25 checks passed
@sichanyoo sichanyoo deleted the chore/make-LogAgent-conform-to-Sendable branch March 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants