chore: lint _all_ the things #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianbotsf
added
the
no-changelog
lauzadis
approved these changes
May 2, 2023
aajtodd
approved these changes
May 2, 2023
| @@ -178,6 +173,7 @@ tasks.register<JavaExec>("ktlint") { | |||
| classpath = configurations.getByName("ktlint") | |||
| main = "com.pinterest.ktlint.Main" | |||
| args = lintPaths | |||
| jvmArgs("--add-opens", "java.base/java.lang=ALL-UNNAMED") | |||
There was a problem hiding this comment.
Question: What does this do?
There was a problem hiding this comment.
I don't know exactly what it does but it was necessary to get around issues when running gg ktlintFormat. I saw instances of NoClassDefFoundError and InaccessibleObjectException and the related GH issues mentioned this as a solution. KtLint's integrations guide also mentions this may be necessary, albeit in the context of custom Gradle integration (rather than via a plugin like we're doing).
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
(none)
Description of changes
Similar to smithy-kotlin#847, update the lint paths by including all *.kt and *.kts files and then specifically excluding generated code. Fortunately, no regular Kotlin files were impacted (the allowlist was already pretty comprehensive) and the changes are all in Gradle scripts.
No copyright header rule was updated because it doesn't exist in the aws-sdk-kotlin repo. That will have to wait until our linting config is commonized into a separate repo.
Most of this PR is the lint fixes themselves. The only interesting file is build.gradle.kts.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.