impl PartialEq for HandlerError #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
While making some attempts to sketch out what unit testing might look like for this project I quickly realized that the core user interface, Handler, does not lend itself well to the out of the box testing interfaces, like
assert_eq!because Handler results can yield HandlerErrors which do not implement PartialEq. I realize HandlerError is in a bit in flux but I think we should still have a basic store for unit testability with Rust's default toolchain.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.