generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 49
Optimize the sizes of buffers requested from mem pool #563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
DmitriyMusatkin
wants to merge
15
commits into
main
Choose a base branch
from
get_size
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
==========================================
+ Coverage 88.72% 88.73% +0.01%
==========================================
Files 22 22
Lines 6767 6776 +9
==========================================
+ Hits 6004 6013 +9
Misses 763 763
🚀 New features to boost your workflow:
|
TingDaoK
reviewed
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
There were a couple corner cases where scheduler would request more mem from mem pool than needed, ex. for a small ranged get, the scheduler requested part sized buffer anyways. With default mem pool, the mem pool will still do part size for that case (we can optimize that later), but for custom mem pools we want to provide an option to do more accurate allocation.
Note: that for put streaming we cant always request an accurate buffer cause we really on finding eof in the stream, so its kinda of a chicken and egg problem
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.