macOS Final Pass #766
Open
macOS Final Pass #766
+514
−596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbSteveK
changed the base branch from
main
to
macos-secitem/filebased-keychain
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## macos-secitem/filebased-keychain #766 +/- ##
=================================================================
Coverage 78.76% 78.76%
=================================================================
Files 30 30
Lines 6410 6410
=================================================================
Hits 5049 5049
Misses 1361 1361 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sfod
force-pushed
the
macos-final-changes
branch
from
f9683bb to
ae24752
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final Pass to get macOS branch ready for merge.
Primarily consists of removing any iOS, Apple Network Framework, or Secitem specific branching and using APPLE as everything on apple will use both network framework and secitem now. Old Security Framework used by macOS before the migration has also been cleaned up.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.