fix: add path traversal protection in markdownlint-frontmatter#122
Open
scottschreckengaust wants to merge 1 commit intomainfrom
Open
fix: add path traversal protection in markdownlint-frontmatter#122scottschreckengaust wants to merge 1 commit intomainfrom
scottschreckengaust wants to merge 1 commit intomainfrom
Conversation
Resolves code scanning alert #136 (CWE-22). The schema file path was constructed dynamically without validation. Added path.normalize() and a startsWith guard to ensure the resolved path stays within the schemas directory. Moved the nosemgrep suppression to the same line as the fs.readFileSync call so it is reliably honored in SARIF output. Co-Authored-By: Claude Opus 4.6 <[email protected]>
krokoko
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/markdownlint-frontmatter.cjspath.normalize()+startsWithguard to validate the schema file path stays within theschemas/directory before readingnosemgrepsuppression to the same line asfs.readFileSyncso it is reliably honored in SARIF output (the previous-line comment was not being respected in CI)Test plan
mise run buildpasses locally with no semgrep findings for this fileGenerated with Claude Code
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.