Skip to content

Revert the PR changes 5122 #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 20, 2025
Merged

Revert the PR changes 5122 #5134

merged 33 commits into from
Apr 20, 2025

Conversation

rsareddy0329
Copy link
Contributor

@rsareddy0329 rsareddy0329 commented Apr 17, 2025

Issue #, if available:
https://t.corp.amazon.com/P225801207/overview

Description of changes:

  • Revert PR 5122 changes, due to issues with other processor codeflows

Testing done:

  • yes, relevant tests were successful

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

  • I have read the CONTRIBUTING doc
  • I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
  • I used the commit message format described in CONTRIBUTING
  • I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
  • I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
  • I have checked that my tests are not configured for a specific region or account (if appropriate)
  • I have used unique_name_from_base to create resource names in integ tests (if appropriate)
  • If adding any dependency in requirements.txt files, I have spell checked and ensured they exist in PyPi

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Roja Reddy Sareddy and others added 30 commits January 29, 2025 00:07
…aining script which can misguide users.Training script can be of latest version based on the support provided by framework_version of the container
@rsareddy0329 rsareddy0329 marked this pull request as ready for review April 17, 2025 22:51
@rsareddy0329 rsareddy0329 requested a review from a team as a code owner April 17, 2025 22:51
@rsareddy0329 rsareddy0329 requested a review from bhadrip April 17, 2025 22:51
@rsareddy0329 rsareddy0329 merged commit 06801a4 into aws:master Apr 20, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants