Expose TLS error to Subscribers using on_tls_handshake_failed #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to always use the Error rather than only when std feature is enabled. This was stabilized in Rust 1.81, which is below our current MSRV.
This allows propagating out the Display/Debug impl for the error, rather than just the &'static str we can capture into s2n-quic-transport's Errors.
Mark-Simulacrum
force-pushed
the
expose-error-to-subscriber
branch
from
7320bdb to
0fa3937
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Summary:
Resolved issues:
cc #2616 (not fixed at all, just helps mitigate the lack of it)
Description of changes:
This allows propagating out the Display/Debug impl for the error, rather than just the &'static str we can capture into s2n-quic-transport's Errors.
Call-outs:
n/a
Testing:
I don't think tests are particularly relevant here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.