chore: add configurable ttl to post install hook #6766
Conversation
✅ Deploy Preview for karpenter-docs-prod ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Pull Request Test Coverage Report for Build 10400404075Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
I had the same issues, please fix it |
| @@ -12,7 +12,7 @@ metadata: | |||
| {{- toYaml . | nindent 4 }} | |||
| {{- end }} | |||
| spec: | |||
| ttlSecondsAfterFinished: 0 | |||
| ttlSecondsAfterFinished: {{ .Values.postInstallHook.ttlSecondsAfterFinished }} | |||
There was a problem hiding this comment.
This mainly looks good, but I think we need to drop the annotation for hook-succeeded and hook-failed for the helm.sh/hook-delete-policy: https://helm.sh/docs/topics/charts_hooks/#hook-deletion-policies This will ensure that we are drive the clean-up process as part of the ttlSecondsAfterFinished
There was a problem hiding this comment.
Makes sense to move these annotations out to a .Values.postInstallHook.annotations map then?
There was a problem hiding this comment.
Yeah, if user want that level of configuration that would make sense
|
Closing as the job has been removed. |
Fixes #6765
Description
Added configuration option for the ttlSecondsAfterFinished field on the post install job so that Argo CD based installs can complete (as Argo CD needs to reap the job rather than the internal controller).
How was this change tested?
Forked the chart, installed it with Argo CD with a value of 30 for
.Values.postInstallHook.ttlSecondsAfterFinished.Does this change impact docs?
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.