Skip to content

Add failure domains into missing permissions logic #9612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

charles-large
Copy link
Member

Issue #, if available:
issue
Description of changes:

  • Adjusted missing permissions code to take a common interface between vspheremachineconfigs and failuredomains to compare similar values
  • Added compute cluster permissions checking (using AdminPrivs file)
  • Unit testing
  • Here is an example missing permissions output when user has no permissions.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 14, 2025
Copy link

codecov bot commented Apr 14, 2025

Codecov Report

Attention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.75%. Comparing base (f33e91e) to head (1da52b1).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
pkg/providers/vsphere/validator.go 96.61% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9612      +/-   ##
==========================================
+ Coverage   69.73%   69.75%   +0.02%     
==========================================
  Files         672      672              
  Lines       49550    49616      +66     
==========================================
+ Hits        34555    34612      +57     
- Misses      13219    13226       +7     
- Partials     1776     1778       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@charles-large charles-large force-pushed the fd-missing-permissions branch 4 times, most recently from 0226c0e to 8356abf Compare April 14, 2025 19:30
@charles-large charles-large marked this pull request as draft April 18, 2025 18:38
@charles-large charles-large force-pushed the fd-missing-permissions branch from 8356abf to 1da52b1 Compare April 18, 2025 21:28
@charles-large charles-large marked this pull request as ready for review April 18, 2025 21:33
@rajeshvenkata
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rajeshvenkata

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rajeshvenkata
Copy link
Member

/cherry-pick release-0.22

@eks-distro-pr-bot
Copy link
Contributor

@rajeshvenkata: once the present PR merges, I will cherry-pick it on top of release-0.22 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 575f2b1 into aws:main Apr 18, 2025
10 of 11 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@rajeshvenkata: new pull request created: #9647

In response to this:

/cherry-pick release-0.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants