Skip to content

Conversation

@kzr-at-amazon
Copy link
Contributor

Problem

  • Signing out did not clear the DZ client, so when user re-tries signing in with corrected region, they cannot access the targeted domain.

Solution

  • Dispose smuAuthProvider when signing out, within authProvider dispose, the DZ clients will also be disposed

  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kzr-at-amazon kzr-at-amazon requested a review from a team as a code owner December 17, 2025 21:56
@github-actions
Copy link

  • This pull request modifies code in src/* but no tests were added/updated.
    • Confirm whether tests should be added or ensure the PR description explains why tests are not required.
  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

})
}

authProvider.dispose()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move this up before the refresh? In case the refresh is expected to rely on some state in AuthProvider, that will also get cleared. Line 396 maybe.

@laileni-aws laileni-aws enabled auto-merge (squash) December 23, 2025 18:32
@laileni-aws laileni-aws merged commit 9083350 into aws:master Dec 23, 2025
49 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants