Moving workspace folder addition in import Lambda flow #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/runintegrationtests |
justinmk3
approved these changes
Nov 5, 2020
justinmk3
pushed a commit
that referenced
this pull request
Nov 30, 2023
* feat(appcomposer): add webview meta tags Problem: The current build of Application Composer has no way of supporting localization, dark mode, or feature flags. Solution: This adds meta tags to the webview to pass this information into Application Composer. --------- Co-authored-by: Jacob Largent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lambda Import workflow now adds workspace folders later in the workflow. This does not affect functionality.
Motivation and Context
Found a weird bug with adding workspace folders to VS Code: if a user has an instance of VS Code open that is open to a folder, but the folder is not part of a workspace, and the user attempts to add a workspace folder via extension command, it appears that the extension host restarts, failing the command mid-flight. This does not happen if nothing is open in VS Code (instead, the whole IDE restarts) or if a workspace is in place (works as intended). This helps to mitigate this issue: the user may see an issue with a launch config being added, but should have their Lambda downloaded and unzipped correctly.
As a side note, a deeper dive here did find some issues with the Lambda pulling, but this should be fixed by #1379
Related Issue(s)
Affected by microsoft/vscode#109991
Testing
Manual testing: Lambda downloads and unzips reliably and is found in the workspace after the folder is added (extension still restarts though)
Screenshots (if appropriate)
Checklist
npm run newChangeLicense
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.