Ensure wrapped driver exists on classpath at time of registration#164
Open
imaperson wants to merge 6 commits intoaws:masterfrom
Open
Ensure wrapped driver exists on classpath at time of registration#164imaperson wants to merge 6 commits intoaws:masterfrom
imaperson wants to merge 6 commits intoaws:masterfrom
Conversation
This is important to ensure all the jars needed are available to use the driver. This also allows the jar to be more easily used by frameworks like quarkus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Initialization and registration of the AWS driver can happen successfully while later JDBC actions failed due to the wrapped driver's not existing. For example, if "org.postgresql.Driver" does not exist on the classpath this will be discovered later than it needs to be at runtime. Additionally, loading the drivers during the registration process facilitates detection of required classes by frameworks such as quarkus when building optimized builds.
To ensure required classes are loaded during registration, I added a called to "getWrappedDriver()" to the end of the AWSSecretsManagerDriver(SecretCache cache) constructor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.