fix: project version in VersionInfo.cs
#182
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #182 +/- ##
==========================================
+ Coverage 72.52% 73.18% +0.65%
==========================================
Files 6 5 -1
Lines 222 220 -2
Branches 23 23
==========================================
Hits 161 161
+ Misses 52 50 -2
Partials 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
simonmarty
requested changes
Oct 13, 2025
i-am-SR
reviewed
Oct 13, 2025
Comment on lines
+1
to
+2
| // This file is auto-generated during build from PackageVersion in the .csproj file. | ||
| // Do not edit manually. See GenerateVersionInfo target in Amazon.SecretsManager.Extensions.Caching.csproj |
There was a problem hiding this comment.
The file VersionInfo.g.cs is being auto-generated so why have the file VersionInfo.cs at all? Shouldn't we delete this?
Also, have we tested this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
The project version in
VersionInfo.cswas incorrectly set to1.1.0.0. Fixed to match the latest released version of the library (v2.0.0).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.