Skip to content

fix: add streaming flag and error handling #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

fix: add streaming flag and error handling #3214

wants to merge 6 commits into from

Conversation

@yenfryherrerafeliz
Copy link
Contributor

@yenfryherrerafeliz yenfryherrerafeliz commented Nov 20, 2025 •
edited
Loading

Issues #3124, #3018:

Description of changes:

  • Evaluates if a client's operation requires http streaming flag to be set to true, and if so then it pass the option along.
  • Make error parsers to reused a parsed body for scenario where the body is non seekable and can't be consumed again.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@yenfryherrerafeliz
fix: add streaming flag and error handling
3f18ff8 
- Evaluates if a client's operation requires http streaming flag to be set to true, and if so then it pass the option along.
- Make error parsers to reused a parsed body for scenario where the body is non seekable and can't be consumed again.

Also change the condition:
 (!$body->isSeekable() || $body->getSize())
To:
 (!$body->isSeekable() || !$body->getSize())

The reason is that a stream non seekable will most likely not have a size, which means this condition will always be true.
@yenfryherrerafeliz
revert: revert condition change
ee873c7 
Reverted the condition to what it was:
(!$body->isSeekable() || $body->getSize())

Why?, I need to understand better what is the usage of this condition before changing. It was breaking some integ tests.
@yenfryherrerafeliz
fix: handle empty body responses
a78557b 
- When a response body is empty then we dont try to parse it.
- When the response body is non seekable then, we read the full body before parsing.
@yenfryherrerafeliz
Copy link
Contributor Author

yenfryherrerafeliz commented Nov 20, 2025 

Running integ tets
vendor/bin/behat --format=progress --tags=integ
...................................................................... 70
...................................................................... 140
...................................................................... 210
......................................

66 scenarios (66 passed)
248 steps (248 passed)
5m9.29s (45.13Mb)
Running smoke tests
vendor/bin/behat --format=progress --suite=smoke --tags='~@noassumerole'
...................................................................... 70
...................................................................... 140
...................................................................... 210
............

111 scenarios (111 passed)
222 steps (222 passed)
0m45.99s (95.47Mb)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stobrien89 stobrien89 Awaiting requested review from stobrien89

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@yenfryherrerafeliz