V3: Fixed an issue where IAmazonS3.EnsureBucketExists(Async) was throwing an exception if S3 bucket already exists in the executing account.

[ashishdhingra]

Description

Fixed an issue where IAmazonS3.EnsureBucketExists(Async) was throwing an exception if S3 bucket already exists in the executing account.

Kindly note below for 1st version:

• Refer Using the handle method to filter inner exceptions on how to handle exceptions when using async Task based version.
• After handling exception for async version, we return Task.FromResult(0). This is because:
  • If we return the original Task object, it re-throws exception in the calling awaited thread.
  • Task.CompletedTask doesn't exist in NET45 target.

Motivation and Context

Issue #3807

Testing

• Added integration test.
• Dry-run DRY_RUN-32d10e46-52d0-421f-9bc7-943cdd6348cd completed successfully.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• My code follows the code style of this project
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have read the README document
• I have added tests to cover my changes
• All new and existing tests passed

License

• I confirm that this pull request can be released under the Apache 2 license

[normj]

You should just use the async/await something like.

async Task ICoreAmazonS3.EnsureBucketExistsAsync(string bucketName)
{
   try
   {
        await this.PutBucketAsync(bucketName);
   }
   catch(BucketAlreadyOwnedByYouException)
   {
   }
}

[ashishdhingra]

The exception in this.PutBucketAsync(bucketName) is thrown in another thread and based on my testing, catch block wouldn't handle it. Hence, I needed to resort to exception handling based on Microsoft's documentation. The only difference I see in your proposed code is addition of async to method signature. Let me give it a try.

[ashishdhingra]

Fixed. It's working. Starting dry-run.