Skip to content

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Sep 26, 2025

Issue

Internal JS-6197

Description

Adds request/response mapping validation tests for S3 Transfer Manager to ensure all required fields are properly copied between PutObject and multipart upload operations, to be compliant with the specification.

  • Captures wire logs from 6MB upload using 4 requests (CreateMultipartUpload → 2x UploadPart → CompleteMultipartUpload) and validates that CompleteMultipartUpload response fields are properly mapped to Upload.done() output.
  • Validates that PutObject response fields for small files are correctly mapped to Upload.done() output

Testing

Locally

dev-dsk-smilkuri-1a-17aece6b % yarn test:integration

 RUN  v3.2.4 /local/home/smilkuri/aws-sdk-js-v3/lib/lib-storage

 ✓ src/lib-storage.integ.spec.ts (2 tests) 204ms
   ✓ lib storage integration test > verifies CompleteMultipartUpload response is properly mapped to Upload response for large files 195ms
   ✓ lib storage integration test > verifies PutObject response is properly mapped to Upload response for small files 7ms

 Test Files  1 passed (1)
      Tests  2 passed (2)
   Start at  15:43:56
   Duration  1.29s (transform 525ms, setup 0ms, collect 763ms, tests 204ms, environment 0ms, prepare 119ms)

@smilkuri smilkuri marked this pull request as ready for review October 2, 2025 16:43
@smilkuri smilkuri requested a review from a team as a code owner October 2, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants