fix(lib-storage): improve concurrency and abortion management

[matthieusieben]

Issue

#6426

Description

This change improves the following aspects of the lib:

• Options use an abortSignal instead of an abortController (still available but deprecated) in order to be more consistent with other APIs. This also allows to use Upload with AbortSignal.timeout()

    await new Upload({
      client,
      params,
      abortSignal: AbortSignal.timeout(10_000)
    }).done()

• The code no longer returns control to the caller if operations are still pending in the background. Before, a Promise.race would cause done() to reject as soon as the abort controller is aborted, but would not wait for pending tasks to complete. This prevents user code from properly controlling concurrency. This change also avoids Upload from seemingly failing if they are aborted during the PutObjectTaggingCommand phase, and the upload acutally succeeded (since nothing actually cancelled it).
• Uploads of individual chunks will be cancelled as soon as the upload is aborted, instead of waiting for the chunk upload to complete before cancelling the whole process. This allows to ensure that control is given back to the user code asap.
• The type of the abortController option was updated to not cause a typing issue when used with global AbortController (no longer need to @ts-ignore).

Testing

Not tested.

Additional context

We encountered upload "hangs" in our code, similar to those described in #6426 . While investigating, I encountered several opportunities for improvement, as noted in the Description above.

Checklist

• If the PR is a feature, add integration tests (*.integ.spec.ts).
• If you wrote E2E tests, are they resilient to concurrent I/O?
• If adding new public functions, did you add the @public tag and enable doc generation on the package?

---

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

[matthieusieben]

The race here could cause the returned promise to be rejected when __doMultipartUpload actually succeeds (and is still working on updating tags).

[matthieusieben]

Hey @kuhe @trivikr , sorry to bother you. Any chance you'd might be giving this a look ?

[matthieusieben]

There was no point in keeping a reference on the instance as it was not used anywhere else.

[matthieusieben]

The code technically supports IAbortSignal but since those are kinda deprecated, and this is a new feature, there is no point in adding more legacy here.