Add all streaming operation to s3 checksums tests #5998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o olapplin/s3-checksums-tests # Conflicts: # test/s3-tests/pom.xml # test/s3-tests/src/it/java/software/amazon/awssdk/services/s3/BodyType.java # test/s3-tests/src/it/java/software/amazon/awssdk/services/s3/checksum/ChecksumIntegrationTesting.java
seperate data-place, upload and download test avoid running useless tests cases
zoewangg
reviewed
Apr 3, 2025
...s3-tests/src/it/java/software/amazon/awssdk/services/s3/regression/BaseS3RegressionTest.java
Show resolved
Hide resolved
.../java/software/amazon/awssdk/services/s3/regression/DataplaneOperationRegressionTesting.java
Outdated
Show resolved
Hide resolved
...t/java/software/amazon/awssdk/services/s3/regression/DownloadStreamingRegressionTesting.java
Outdated
Show resolved
Hide resolved
.../it/java/software/amazon/awssdk/services/s3/regression/UploadStreamingRegressionTesting.java
Show resolved
Hide resolved
.../it/java/software/amazon/awssdk/services/s3/regression/UploadStreamingRegressionTesting.java
Show resolved
Hide resolved
.../it/java/software/amazon/awssdk/services/s3/regression/UploadStreamingRegressionTesting.java
Show resolved
Hide resolved
| // Async java based clients don't currently support unknown content-length bodies | ||
| Assumptions.assumeFalse( | ||
| (config.getBaseConfig().getFlavor() == S3ClientFlavor.ASYNC_JAVA_BASED || | ||
| config.getBaseConfig().getFlavor() == S3ClientFlavor.TM_JAVA) |
There was a problem hiding this comment.
This should be supported in multipart client, right?
There was a problem hiding this comment.
there are still tests that are run with the multipart client, without multipart, for example the small content size
There was a problem hiding this comment.
Do we have a test case covering multipart client + unknown content-length?
…object, precalculated crc32 when possible, rename S3ClientFlavor fields,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more test cases to s3 checksums tests:
RequestBodyandResponseTransformerto the test suite.Prepare for Codebuild execution for the tests suite