Skip to content

Pr/3551 - MinGW test failure fixes #3555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 22, 2025
Merged

Pr/3551 - MinGW test failure fixes #3555

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc636fb
fix tmpnam_s call error while using MinGW
Sep 17, 2025
53f65ec
fix CreateDirectoryIfNotExists trim fault about drive letter while us…
Sep 17, 2025
1450df7
FileSystem.cpp - Fix MinGW version check to check for definition first
sbaluja Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/aws-cpp-sdk-core/source/platform/windows/FileSystem.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ bool CreateDirectoryIfNotExists(const char* path, bool createParentDirs)
for (size_t i = createParentDirs ? 0 : directoryName.size() - 1; i < directoryName.size(); i++)
{
// Create the intermediate directory if we find a delimiter and the delimiter is not the first char, or if this is the target directory.
if (i != 0 && (directoryName[i] == FileSystem::PATH_DELIM || i == directoryName.size() - 1))
if (i > 2 && (directoryName[i] == FileSystem::PATH_DELIM || i == directoryName.size() - 1))
{
// the last delimeter can be removed safely.
if (directoryName[i] == FileSystem::PATH_DELIM)
Expand Down Expand Up @@ -317,6 +317,11 @@ Aws::String CreateTempFilePath()
// Definition from the MSVC stdio.h
#define L_tmpnam_s (sizeof("\\") + 16)
#endif

#if defined(__MINGW64_VERSION_MAJOR) && __MINGW64_VERSION_MAJOR < 12
#undef L_tmpnam_s
#define L_tmpnam_s 260
#endif
char s_tempName[L_tmpnam_s+1];

/*
Expand All @@ -328,7 +333,7 @@ Aws::String CreateTempFilePath()
for more details.
*/

#if _MSC_VER >= 1900
#if _MSC_VER >= 1900 || defined(_UCRT)
tmpnam_s(s_tempName, L_tmpnam_s);
#else
s_tempName[0] = '.';
Expand Down
Loading