Skip to content

Conversation

ajewellamz
Copy link
Contributor

…n context. If the supplied encryption context does not exactly match the encryption context used for PutObject, the operation will fail.

Issue #, if available:

Description of changes:

Added overload to GetObject in encryption client to provide encryption context, which must match that used in the original PutObject.

Check all that applies:

  • Did a review by yourself.
  • Added proper tests to cover this PR. (If tests are not applicable, explain.)
  • [X ] Checked if this PR is a breaking (APIs have been changed) change. ISN'T
  • [X ] Checked if this PR will not introduce cross-platform inconsistent behavior.
  • Checked if this PR would require a ReadMe/Wiki update.

Check which platforms you have built SDK on to verify the correctness of this PR.

  • Linux
  • Windows
  • Android
  • [ X] MacOS
  • IOS
  • Other Platforms

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sbiscigl sbiscigl force-pushed the ajewell/ec-for-get-object branch from 3cf2931 to 3ee01e4 Compare September 22, 2025 17:18
Copy link

@seebees seebees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a very conservative change. We are not modifying the Materials object and this is OK for KMS because we verify strict equality, and Simple materials because they already fail.

@sbiscigl sbiscigl force-pushed the ajewell/ec-for-get-object branch 2 times, most recently from 0ba5cd9 to be430f4 Compare September 23, 2025 02:12
@sbiscigl sbiscigl force-pushed the ajewell/ec-for-get-object branch from be430f4 to 641c762 Compare September 23, 2025 15:31
@sbiscigl sbiscigl merged commit c111f05 into main Sep 23, 2025
4 of 6 checks passed
@sbiscigl sbiscigl deleted the ajewell/ec-for-get-object branch September 23, 2025 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants