build: Implicitly enable platform aws when building for neuron #888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwbarrett
reviewed
May 16, 2025
liralon
force-pushed
the
neuron_build_fix
branch
2 times, most recently
from
5fe5436 to
5b59fb7
Compare
|
#894 should resolve the CI failure here. |
Neuron only exists on AWS platform instances, and it does not function correctly when `--enable-platform-aws` is not specified in build. This is because Neuorn relies on the default configuration values per instance type as specified in `platform_data_map[]` array. Such as using RDMA protocol on Trn2. Signed-off-by: Liran Alon <[email protected]>
rauteric
force-pushed
the
neuron_build_fix
branch
from
5b59fb7 to
633af3a
Compare
|
Rebase on master |
bwbarrett
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neuron only exists on AWS platform instances, and it does not function correctly when
--enable-platform-awsis not specified in build.This is because Neuorn relies on the default configuration values per instance type as specified in
platform_data_map[]array. Such as using RDMA protocol on Trn2.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.