Replace struct SignEnclaveInfo with trait PcrSigner
#30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This PR is required by aws-nitro-enclaves-cli/pull/639
Replacing
struct SignEnclaveInfowithtrait PcrSignerallows us to support new signing methods by extendingtrait PcrSignerwithout changing the existing code.Add
struct PrivateKeyPcrSignerfor signingPcrInfowithPrivateKeyAdd
fn get_measurements,struct PcrCoseSign1andstruct SignaturePcrSigner. For security reasons, the private key is usually in a separated environment, so it may not be possible to build an enclave with private key in a single step from the building pipeline. Inspired by Digest Signing in oesign,fn get_measurementsis used to generate measurements without writing output enclave image file.struct PcrCoseSign1is exported to public and provide function to signPcrInfostruct SignaturePcrSigneris used to accept the signature, verify it, and directly write it to the enclave image file.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.