remove isCI from samples

Author: sbSteveK

samples/JavaKeystoreConnect/src/main/java/javakeystoreconnect/JavaKeystoreConnect.java

@@ -20,24 +20,14 @@
 
 public class JavaKeystoreConnect {
 
-    // When run normally, we want to exit nicely even if something goes wrong
-    // When run from CI, we want to let an exception escape which in turn causes the
-    // exec:java task to return a non-zero exit code
-    static String ciPropValue = System.getProperty("aws.crt.ci");
-    static boolean isCI = ciPropValue != null && Boolean.valueOf(ciPropValue);
-
     static CommandLineUtils cmdUtils;
 
     /*
      * When called during a CI run, throw an exception that will escape and fail the exec:java task
      * When called otherwise, print what went wrong (if anything) and just continue (return from main)
      */
     static void onApplicationFailure(Throwable cause) {
-        if (isCI) {
-            throw new RuntimeException("JavaKeystoreConnect execution failure", cause);
-        } else if (cause != null) {
-            System.out.println("Exception encountered: " + cause.toString());
-        }
+        throw new RuntimeException("JavaKeystoreConnect execution failure", cause);
     }
 
     public static void main(String[] args) {

samples/Mqtt5/PubSub/src/main/java/pubsub/PubSub.java

@@ -23,24 +23,10 @@
 
 public class PubSub {
 
-    // When run normally, we want to exit nicely even if something goes wrong
-    // When run from CI, we want to let an exception escape which in turn causes the
-    // exec:java task to return a non-zero exit code
-    static String ciPropValue = System.getProperty("aws.crt.ci");
-    static boolean isCI = ciPropValue != null && Boolean.valueOf(ciPropValue);
-
     static CommandLineUtils cmdUtils;
 
-    /*
-     * When called during a CI run, throw an exception that will escape and fail the exec:java task
-     * When called otherwise, print what went wrong (if anything) and just continue (return from main)
-     */
     static void onApplicationFailure(Throwable cause) {
-        if (isCI) {
-            throw new RuntimeException("Mqtt5 PubSub: execution failure", cause);
-        } else if (cause != null) {
-            System.out.println("Exception encountered: " + cause.toString());
-        }
+        throw new RuntimeException("Mqtt5 PubSub: execution failure", cause);
     }
 
     static final class SampleLifecycleEvents implements Mqtt5ClientOptions.LifecycleEvents {

samples/Mqtt5/SharedSubscription/src/main/java/sharedsubscription/SharedSubscription.java

@@ -21,27 +21,12 @@
 import utils.commandlineutils.CommandLineUtils;
 
 public class SharedSubscription {
-    /**
-     * When run normally, we want to exit nicely even if something goes wrong
-     * When run from CI, we want to let an exception escape which in turn causes the
-     * exec:java task to return a non-zero exit code
-     */
-    static String ciPropValue = System.getProperty("aws.crt.ci");
-    static boolean isCI = ciPropValue != null && Boolean.valueOf(ciPropValue);
 
     /* Used for command line processing */
     static CommandLineUtils cmdUtils;
 
-    /*
-     * When called during a CI run, throw an exception that will escape and fail the exec:java task
-     * When called otherwise, print what went wrong (if anything) and just continue (return from main)
-     */
     static void onApplicationFailure(Throwable cause) {
-        if (isCI) {
-            throw new RuntimeException("Mqtt5 SharedSubscription: execution failure", cause);
-        } else if (cause != null) {
-            System.out.println("Exception encountered: " + cause.toString());
-        }
+        throw new RuntimeException("Mqtt5 SharedSubscription: execution failure", cause);
     }
 
     /**