Skip to content

Commit b00bea7

Browse files
committed
remove mqtt3 from android sample app
1 parent dd7eeaa commit b00bea7

File tree

3 files changed

+1
-35
lines changed

3 files changed

+1
-35
lines changed

samples/Android/README.md

Lines changed: 1 addition & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,7 @@
44
The Android sample builds an app that can be installed and run on an Android Device. The app builds and allows you
55
to run the following [samples](#links-to-individual-sample-readme-files) from aws-iot-device-sdk-java-v2:
66
* [Mqtt5PubSub](../Mqtt5/PubSub/README.md)
7-
* [Mqtt3PubSub](../BasicPubSub/README.md)
87
* [KeyChainPubSub](./AndroidKeyChainPubSub/README.md)
9-
* [Jobs](../Jobs/README.md)
10-
* [Shadow](../Shadow/README.md)
11-
* [CognitoConnect](../CognitoConnect/README.md)
128

139
*__Jump To:__*
1410

@@ -30,7 +26,7 @@ files linked below.
3026
### Files required by all samples:
3127
* `endpoint.txt` - IoT ATS Endpoint
3228

33-
### Required to run Mqtt5PubSub and Mqtt3PubSub samples
29+
### Required to run Mqtt5PubSub sample
3430
* `certificate.pem` - IoT Thing Certificate
3531
* `privatekey.pem` - IoT Thing Private Key
3632

@@ -43,15 +39,6 @@ files linked below.
4339
* `message.txt` - specifies --message CLI argument
4440
* `count.txt` - specifies --count CLI argument
4541

46-
### Required to run Jobs and Shadow sample
47-
* `certificate.pem` - IoT Thing Certificate
48-
* `privatekey.pem` - IoT Thing Private Key
49-
* `thingName.txt` - IoT Thing Name used by sample
50-
51-
### Required to run Cognito Client sample:
52-
* `cognitoIdentity.txt` - Cognito identity ID
53-
* `signingRegion.txt` - Signing region
54-
5542
### Optional files for all Samples:
5643
* `rootca.pem` - override the default system trust store
5744
* `clientId.txt` - specifies --clientId CLI argument
@@ -76,18 +63,8 @@ Android sample app.
7663

7764
[**Mqtt5PubSub**](../Mqtt5/PubSub/README.md)
7865

79-
[**Mqtt3PubSub**](../BasicPubSub/README.md)
80-
8166
[**KeyChainPubSub**](AndroidKeyChainPubSub/README.md)
8267

83-
[**Jobs**](../Jobs/README.md)
84-
85-
[**Shadow**](../Shadow/README.md)
86-
87-
[**CognitoConnect**](../CognitoConnect/README.md)
88-
89-
##### NOTE: The shadow sample does not currently complete on android due to its dependence on stdin keyboard input.
90-
9168

9269
# Trouble Shooting
9370
### Error: The file name must end with .xml

samples/Android/app/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,6 @@ android {
5353
main {
5454
java.srcDir '../../Utils/CommandLineUtils'
5555
java.srcDir '../../Mqtt5/PubSub/src/main/java'
56-
java.srcDir '../../BasicPubSub/src/main/java'
57-
java.srcDir '../../CognitoConnect/src/main/java'
5856
java.srcDir '../AndroidKeyChainPubSub/src/main/java'
5957
java.srcDir 'src/main/java'
6058
}

samples/Android/app/src/main/java/software/amazon/awssdk/iotsamples/MainActivity.java

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,8 @@ public class MainActivity extends AppCompatActivity implements AdapterView.OnIte
3535
private static final Map<String, String> SAMPLES = new LinkedHashMap<String, String>() {{
3636
put("Select a Sample",""); // empty default
3737
put("MQTT5 Publish/Subscribe", "mqtt5.pubsub.PubSub");
38-
put("MQTT3 Publish/Subscribe", "pubsub.PubSub");
3938
put("KeyChain Publish/Subscribe", "androidkeychainpubsub.AndroidKeyChainPubSub");
4039
put("KeyChain Alias Permission", "load.privateKey");
41-
put("Cognito Client", "cognitoconnect.CognitoConnect");
4240
}};
4341

4442
private static final Logger logger = Logger.getLogger(MainActivity.class.getName());
@@ -232,7 +230,6 @@ private String[] sampleArgs(String sampleClassName){
232230
// Missing required arguments will return null
233231
switch(sampleClassName){
234232
case "mqtt5.pubsub.PubSub":
235-
case "pubsub.PubSub":
236233
if (!argSetRequired("--cert", "certificate.pem", args) ||
237234
!argSetRequired("--key", "privatekey.pem", args)) {
238235
return null;
@@ -242,12 +239,6 @@ private String[] sampleArgs(String sampleClassName){
242239
argSetOptional("--count", "count.txt", args);
243240
break;
244241

245-
case "cognitoconnect.CognitoConnect":
246-
if (!argSetRequired("--cognito_identity", "cognitoIdentity.txt", args) ||
247-
!argSetRequired("--signing_region", "signingRegion.txt", args)) {
248-
return null;
249-
}
250-
break;
251242
case "androidkeychainpubsub.AndroidKeyChainPubSub":
252243
if (!argSetRequired("--keychain_alias", "keychainAlias.txt", args)) {
253244
return null;

0 commit comments

Comments
 (0)