Skip to content

Conversation

@vince1995
Copy link

fixes #69

ignore symlinks if they are in in .ebignore
@alexd2580-sf
Copy link

I have my ebcli inside a folder in the repo.
The ebcli folder is ignored within the .ebignore as

ebcli
ebcli/
ebcli/*

With this patch the ebcli/lib64 symling is still included.
To remove it i need to explicitly ignore ebcli/lib64 (and all other symlinks).

IMO ignoring ebcli should suffice to not even include the folder itself (much less its content).

@vince1995
Copy link
Author

Yeah, that's correct. I'm not a python developer and stuck at this piece of code I wrote for an hour. I know that this solution is not optimal but it's working for my team.

@rahulrajaram rahulrajaram added the good first issue Good for newcomers label Apr 2, 2025
@rahulrajaram
Copy link
Collaborator

@vince1995 , sorry for getting to this so late. Any chance you'd like to revise this based on the availability of modern AI tools to make it more comprehensive? Please also ensure you are updating test coverage.

@rahulrajaram rahulrajaram added the bug Something isn't working label Apr 2, 2025
@yuxiang-zhang
Copy link
Contributor

Opened #547 to fix the merge conflicts as 790cde6 removed the for-loop enclosing the changes in this PR

@rahulrajaram
Copy link
Collaborator

#547 supersedes this change. Closing. @vince1995, feel free to reopen if you think there is more to the story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working good first issue Good for newcomers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

.ebignore includes symlinked files in ignored directories

4 participants