Skip to content

Updating error message for IIS installation check in migrate #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rahulrajaram merged 2 commits into from
Sep 30, 2025
Merged

Updating error message for IIS installation check in migrate #570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b01670
updating error message for IIS installation check
scheenk Sep 23, 2025
2b5b273
updating error message in migrate tests
scheenk Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ebcli/controllers/migrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ class Meta:

def do_command(self):
if not is_supported():
raise NotSupportedError("'eb migrate explore' is only supported on Windows")
raise NotSupportedError("'eb migrate explore' is only supported on Windows with IIS installed")
verbose = self.app.pargs.verbose

if verbose:
Expand All @@ -113,7 +113,7 @@ class Meta:

def do_command(self):
if not is_supported():
raise NotSupportedError("'eb migrate cleanup' is only supported on Windows")
raise NotSupportedError("'eb migrate cleanup' is only supported on Windows with IIS installed")
force = self.app.pargs.force
cleanup_previous_migration_artifacts(force, self.app.pargs.verbose)

Expand Down Expand Up @@ -370,7 +370,7 @@ def generate_ms_deploy_source_bundle_remote(
def do_command(self):
remote = self.app.pargs.remote
if not remote and not is_supported():
raise NotSupportedError("'eb migrate' is only supported on Windows")
raise NotSupportedError("'eb migrate' is only supported on Windows with IIS installed")

verbose = self.app.pargs.verbose

Expand Down
8 changes: 4 additions & 4 deletions tests/unit/controllers/test_migrate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
)


@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows")
@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows with IIS installed")
class TestMigrateController(unittest.TestCase):
"""Tests for the migrate controller module."""

Expand Down Expand Up @@ -108,7 +108,7 @@ def test_translate_iis_to_alb_complex_patterns(self):
)


@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows")
@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows with IIS installed")
class TestSortRulesBySpecificity(unittest.TestCase):
"""Tests for the _sort_rules_by_specificity function."""

Expand Down Expand Up @@ -267,7 +267,7 @@ def test_sort_rules_by_specificity_multiple_same_type(self):
self.assertEqual(multiple_hosts_rule, sorted_rules[2])


@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows")
@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows with IIS installed")
class TestCreateAlbRules(unittest.TestCase):
"""Tests for the create_alb_rules function."""

Expand Down Expand Up @@ -519,7 +519,7 @@ def test_create_alb_rules_non_http_protocols(self):
self.assertEqual(rules, []) # Should ignore non-HTTP/HTTPS sites


@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows")
@skipIf(not sys.platform.startswith("win"), "`eb migrate` only supports Windows with IIS installed")
class TestGetSiteConfigs(unittest.TestCase):
"""Tests for the get_site_configs function."""

Expand Down
Loading