Fix issue with eb health --refresh on Windows #540
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrajaram
approved these changes
Apr 16, 2025
shinmc
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Fix issue with eb health --refresh on Windows where the health screen does not load properly and it refreshes frequently. By default, Python's print() function adds a newline character (\n) at the end of the output. The end='' parameter overrides this behavior, telling Python not to add a newline. In Windows this causes a carriage return which resets the cursor location from the location that we saved. As a result, the EB CLI is not able to resume updating and this results in flickering as it reset the cursor position.
Testing:
Tested command on Windows instance, observed properly terminal formatting with refresh occurring at expected interval and no flickering. Test on Mac OS as well and existing behavior is preserved.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.