Peripheral eb migrate enhancements #538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulrajaram
changed the base branch from
PeripheralEBMigrateEnhancements
to
master
This commit adds support 'eb deploy ... --archive <ZIP|dir>' so that customers can point to arbitrary directories/ZIP files to deploy to existing environments. In the presence of the '--archive' argument, 'eb deploy' will ignore the .elasticbeanstalk/config.yml file and operate in its absence. The '--archive' argument will accept directories or ZIP files. If the argument is a directory, 'eb deploy' will ZIP the directory and save it in the '~/.ebartifacts/archives' directory. It will upload it to S3 and invoke EB::CreateApplicationVersion with the artifact. Like with the eb-deploy flow without '--archive', it will proceed to perform an EB::UpdateEnvironment and wait for the update to complete.
rahulrajaram
force-pushed
the
PeripheralEBMigrateEnhancements
branch
from
e9d1efd to
38f78f6
Compare
praegt
approved these changes
Apr 14, 2025
amjadsy
approved these changes
Apr 14, 2025
Collaborator
Author
|
Tests pass against Python 3.12 and 3.9. Will fix Github Action credentials problem subsequently |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
[This PR replaces #535]
This commit adds support
eb deploy ... --archive <ZIP|dir>so that customers can point to arbitrary directories/ZIP files to deploy to existing environments. In the presence of the--archiveargument,eb deploywill ignore the.elasticbeanstalk/config.ymlfile if it is present. If it is not present, it will operate in its absence. The--archiveargument will accept directories or ZIP files. If the argument is a directory,eb deploywill ZIP the directory and save it in the~/.ebartifacts/archivesdirectory. It will upload it to S3 and invokeEB::CreateApplicationVersionwith the artifact. Like with theeb-deployflow without--archive, it will proceed to perform anEB::UpdateEnvironmentand wait for the update to complete.One limitation of the current approach is that it requires the environment to already exist. It would be nice to have
eb deployissue an environment trigger based on theeb create's sane defaults.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.