-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(imagebuilder-alpha): add support for Image Recipe Construct #36092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ozelalisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for considering patterns from previous PRs, left first round of comments
56b4365 to
f41878c
Compare
Pull request has been modified.
336df49 to
aef71d7
Compare
aef71d7 to
7ca9300
Compare
67dc785 to
c40374a
Compare
c40374a to
13ffadb
Compare
Pull request has been modified.
13ffadb to
e0570c3
Compare
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.marketplace-base-image.image-recipe.ts
Outdated
Show resolved
Hide resolved
packages/@aws-cdk/aws-imagebuilder-alpha/test/integ.marketplace-base-image.image-recipe.ts
Show resolved
Hide resolved
c0a198d to
5ca5297
Compare
Pull request has been modified.
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
kumsmrit
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing all the comments
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue
aws/aws-cdk-rfcs#789
Reason for this change
This change adds a new alpha module for EC2 Image Builder L2 Constructs (@aws-cdk/aws-imagebuilder-alpha), as outlined in aws/aws-cdk-rfcs#789. This PR specifically implements the ImageRecipe construct.
Description of changes
This change implements the
ImageRecipeconstruct, which is a higher-level construct of CfnImageRecipe.Example
Describe any new or updated permissions being added
N/A - new L2 construct in alpha module
Description of how you validated changes
Validated with unit tests and integration tests. Manually verified generated CFN templates as well.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license