feat(apigateway): add binaryMediaTypes property to SpecRestApi
#35502
+551
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p2
beginning-contributor
matoom-nomu
force-pushed
the
feature/add-binaryMediaTypes-property-to-SpecRestApi
branch
from
1754d12 to
f37a525
Compare
matoom-nomu
force-pushed
the
feature/add-binaryMediaTypes-property-to-SpecRestApi
branch
from
2c0ed78 to
18974e5
Compare
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-community-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
fixes #35498
Reason for this change
The
SpecRestApiconstruct was missing thebinaryMediaTypesproperty that is available in the regularRestApiconstruct.Description of changes
binaryMediaTypesproperty toSpecRestApiPropsinterface**: This property accepts an array of strings representing binary media types (e.g.,['image/png', 'application/pdf'])SpecRestApiconstructor**: Modified to pass thebinaryMediaTypesproperty to the underlyingCfnRestApiresourcebinaryMediaTypeswithSpecRestApiDescribe any new or updated permissions being added
N/A
Description of how you validated changes
binaryMediaTypesproperty is correctly passed to CloudFormationbinaryMediaTypesconfigurationChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license