fix(lambda-python-alpha): uv python dependencies not enforced #35500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
beginning-contributor
aws-cdk-automation
requested changes
Sep 15, 2025
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
aws-cdk-automation
added
pr-linter/exemption-requested
|
I'm really struggling with writing the tests since the documentation in the readme is only for aws-cdk-lib and I am currently unable to run the integration tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this change
When using UV to install Python dependencies we should install the dependencies that UV listed, instead of having pip installing package dependencies. The later is not deterministic and does not guaranty which version of the packages will be installed by pip. So we should use the
--no-depsoption to instruct pip to not install any package dependencies and instead install the ones that UV listed.UV references:
Description of changes
The code change concerns the @aws-cdk\aws-lambda-python-alpha package
The code change is limited to just adding the
--no-depsoption to theuv pip installcommand when bundling Lambda Python dependencies.Description of how you validated changes
I added a test to the Function integration test with UV to test that the
requestsdependencies are the same version than defined in the uv.lock.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license