feat(neptune-alpha): add engine versions up to v1.4.5.0 #33989

iridescent99 · 2025-03-31T22:56:28Z

Issue # (if applicable)

Reason for this change

Neptune engine versions not up-to-date.

Description of changes

Added engine up to most recently released version as specified here https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases.html

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Integration test

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

hugo-alvarez-bold · 2025-04-09T16:44:08Z

Can i make some changes on this PR?

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

iridescent99 · 2025-04-14T08:35:44Z

Can i make some changes on this PR?

It should be complete now. If anyone wants to take a look and provide me with some feedback?

mazyu36

Thank you for the contribution.
I've added two minor comments.

mazyu36 · 2025-04-14T09:33:45Z

packages/@aws-cdk/aws-neptune-alpha/lib/cluster.ts

+  /**
+   * Neptune engine version 1.4.4.0
+   */
+  public static readonly V1_4_4_0 = new EngineVersion('1.4.4.0');



Could you also add ver 1.4.5.0?

https://docs.aws.amazon.com/neptune/latest/userguide/engine-releases.html

mazyu36 · 2025-04-14T09:34:33Z

packages/@aws-cdk/aws-neptune-alpha/test/integ.cluster-ev14.ts

+  testCases: [stack],
+});
+
+app.synth();


This line is not needed.
Could you please remove it?

…sions

iridescent99 · 2025-04-14T13:41:23Z

Thank you for the contribution. I've added two minor comments.

Thank you for the feedback. I implemented the changes you suggested

mazyu36

Thanks!

paulhcsun · 2025-04-14T22:39:19Z

Thanks for adding these missing versions! And thank you for helping to review @mazyu36 @masterhugo!

paulhcsun · 2025-04-14T22:39:24Z

@Mergifyio update

mergify · 2025-04-14T22:39:54Z

update

☑️ Nothing to do

queue-position = -1 [📌 update requirement]
#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]

mergify · 2025-04-14T23:06:57Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

Pull request has been modified.

iridescent99 · 2025-04-15T08:13:34Z

Thanks for adding these missing versions! And thank you for helping to review @mazyu36 @masterhugo!

Sorry, I think I accidentally cancelled the merge by updating it with the main branch. Rookie mistake, won't happen again!

paulhcsun · 2025-04-15T18:10:38Z

@Mergifyio update

mergify · 2025-04-15T18:10:59Z

update

❌ Mergify doesn't have permission to update

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/codecov.yml without workflows permission

paulhcsun · 2025-04-15T18:11:51Z

@Mergifyio update

mergify · 2025-04-15T18:11:58Z

update

☑️ Nothing to do

#commits-behind > 0 [📌 update requirement]
-closed [📌 update requirement]
-conflict [📌 update requirement]
queue-position = -1 [📌 update requirement]

mergify · 2025-04-15T18:42:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2025-04-15T18:45:45Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

paulhcsun · 2025-04-15T18:52:09Z

@iridescent99 No worries! I think the merge had already failed before you Updated Branch due some mergify issue. I've re-approved and it should be queued to merge now!

mergify · 2025-04-15T18:53:45Z

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated.

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

masterhugo · 2025-04-15T20:38:32Z

same error 🥹 Error message: Unable to get ACTIONS_ID_TOKEN_REQUEST_URL env variable

Pull request has been modified.

paulhcsun · 2025-04-15T23:29:17Z

@Mergifyio requeue

mergify · 2025-04-15T23:29:37Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

aws-cdk-automation · 2025-04-15T23:58:27Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 040d3cd
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2025-04-15T23:58:47Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2025-04-15T23:59:03Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

updated versions up to v.1.4.4.0

9f84794

aws-cdk-automation requested a review from a team March 31, 2025 22:56

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Mar 31, 2025

iridescent99 changed the title ~~feat(aws-neptune-alpha): add engine versions up to v.1.4.4.0~~ feat(aws-neptune-alpha): add engine versions up to v1.4.4.0 Mar 31, 2025

aws-cdk-automation previously requested changes Mar 31, 2025

View reviewed changes

Roos Vroon and others added 3 commits April 1, 2025 01:29

remove trailing spaces

7a74aa8

Align jsdoc

f8b920a

Merge branch 'main' into neptune/update-engine-versions

2765e79

github-actions bot mentioned this pull request Apr 1, 2025

Monthly PR metrics report #33994

Open

iridescent99 changed the title ~~feat(aws-neptune-alpha): add engine versions up to v1.4.4.0~~ feat(neptune-alpha): add engine versions up to v1.4.4.0 Apr 11, 2025

iridescent99 and others added 4 commits April 11, 2025 17:02

add test for v1.4.0.0

0d4c06d

Merge branch 'main' into neptune/update-engine-versions

e079a68

integ test + trailing comma

f6e61c0

snapshots

a5cb8e9

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 11, 2025

mazyu36 suggested changes Apr 14, 2025

View reviewed changes

iridescent99 added 2 commits April 14, 2025 14:20

Merge remote-tracking branch 'og/main' into neptune/update-engine-ver…

a697d63

…sions

add v1.4.5

e4436e2

iridescent99 changed the title ~~feat(neptune-alpha): add engine versions up to v1.4.4.0~~ feat(neptune-alpha): add engine versions up to v1.4.5.0 Apr 14, 2025

Merge branch 'main' into neptune/update-engine-versions

142b347

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Apr 14, 2025

mazyu36 approved these changes Apr 14, 2025

View reviewed changes

masterhugo approved these changes Apr 14, 2025

View reviewed changes

Merge branch 'main' into neptune/update-engine-versions

c7197ab

aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 14, 2025

Merge branch 'main' into neptune/update-engine-versions

6c9046c

paulhcsun previously approved these changes Apr 15, 2025

View reviewed changes

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Apr 15, 2025

Merge branch 'main' into neptune/update-engine-versions

040d3cd

paulhcsun approved these changes Apr 15, 2025

View reviewed changes

mergify bot merged commit 07f1d0a into aws:main Apr 15, 2025
15 of 17 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(neptune-alpha): add engine versions up to v1.4.5.0 #33989

feat(neptune-alpha): add engine versions up to v1.4.5.0 #33989

iridescent99 commented Mar 31, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

hugo-alvarez-bold commented Apr 9, 2025

iridescent99 commented Apr 14, 2025

mazyu36 left a comment

mazyu36 Apr 14, 2025

mazyu36 Apr 14, 2025

iridescent99 commented Apr 14, 2025

mazyu36 left a comment

paulhcsun commented Apr 14, 2025

paulhcsun commented Apr 14, 2025

mergify bot commented Apr 14, 2025

mergify bot commented Apr 14, 2025

iridescent99 commented Apr 15, 2025 •

edited

Loading

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

mergify bot commented Apr 15, 2025

mergify bot commented Apr 15, 2025

paulhcsun commented Apr 15, 2025 •

edited

Loading

mergify bot commented Apr 15, 2025

masterhugo commented Apr 15, 2025

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

aws-cdk-automation commented Apr 15, 2025

mergify bot commented Apr 15, 2025

github-actions bot commented Apr 15, 2025

feat(neptune-alpha): add engine versions up to v1.4.5.0 #33989

feat(neptune-alpha): add engine versions up to v1.4.5.0 #33989

Conversation

iridescent99 commented Mar 31, 2025 • edited Loading

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

aws-cdk-automation left a comment • edited Loading

Choose a reason for hiding this comment

hugo-alvarez-bold commented Apr 9, 2025

iridescent99 commented Apr 14, 2025

mazyu36 left a comment

Choose a reason for hiding this comment

mazyu36 Apr 14, 2025

Choose a reason for hiding this comment

mazyu36 Apr 14, 2025

Choose a reason for hiding this comment

iridescent99 commented Apr 14, 2025

mazyu36 left a comment

Choose a reason for hiding this comment

paulhcsun commented Apr 14, 2025

paulhcsun commented Apr 14, 2025

mergify bot commented Apr 14, 2025

☑️ Nothing to do

mergify bot commented Apr 14, 2025

iridescent99 commented Apr 15, 2025 • edited Loading

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

❌ Mergify doesn't have permission to update

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

☑️ Nothing to do

mergify bot commented Apr 15, 2025

mergify bot commented Apr 15, 2025

paulhcsun commented Apr 15, 2025 • edited Loading

mergify bot commented Apr 15, 2025

masterhugo commented Apr 15, 2025

paulhcsun commented Apr 15, 2025

mergify bot commented Apr 15, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

aws-cdk-automation commented Apr 15, 2025

AWS CodeBuild CI Report

mergify bot commented Apr 15, 2025

github-actions bot commented Apr 15, 2025

iridescent99 commented Mar 31, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

iridescent99 commented Apr 15, 2025 •

edited

Loading

paulhcsun commented Apr 15, 2025 •

edited

Loading