fix(cursor, fetch_dataframe): use column names in cursor's description as is #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n as is Previously, the Cursor.fetch_dataframe method lowercased column names preemptively, thus not respecting the active case-sensitivity configuration value. This could lead to issues, when e.g. two different columns resolved to the same name when lowercased. This commit ensures the resulting DataFrame's columns are the same as the ones in the cursor's description, thus reflecting Redshift's behavior and respecting the underlying case-sensitivity configuration.
|
Hey @Brooke-white 👋 Just wondering if there are any updates here. Let me know if there's anything I can help with to get this PR reviewed. EDIT: I just saw that you're no longer working at AWS Redshift, apologies! Could you point me to someone that I could reach out to for this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
Cursor.fetch_dataframemethod lowercased column names preemptively, thus not respecting the case-sensitivity configuration value. This could lead to issues, when e.g. two different columns resolved to the same name when lowercased.This PR fixes the issue by ensuring the resulting
DataFrame's columns are the same as the ones in the cursor'sdescriptionattribute, thus making the driver match Redshift's behavior.Motivation and Context
Fixes #238
Testing
Implemented a unit test that demonstrates how
fetch_dataframepreserves the column names as they appear in the cursor'sdescriptionattribute.After making the change, I ran
python -m pytest test/unitin a fresh environment and observed all tests succeeding:Types of changes
Checklist
./build.shsucceedspytest test/unitand they are passing.License