-
Notifications
You must be signed in to change notification settings - Fork 120
feat(/tools): update trustall UX, /trust and /untrust capability #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1200 +/- ##
==========================================
- Coverage 14.07% 14.06% -0.01%
==========================================
Files 2366 2366
Lines 205628 205665 +37
Branches 185992 186029 +37
==========================================
- Hits 28936 28934 -2
- Misses 175256 175295 +39
Partials 1436 1436 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
crates/q_cli/src/cli/chat/mod.rs
Outdated
const TRUST_ALL_TEXT: &str = color_print::cstr! {"\n<green!>All tools are now trusted (<red!>!</red!>). This <bold>disables</bold> acceptance prompting.\ | ||
\nAgents can sometimes do unexpected things so understand the risks.</green!>"}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe say ".... Q will execute tools without asking for confirmation."
it's shorter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I received feedback that warning was too short 😔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh then maybe replace "This disables...prompting." with "Q will execute tools without asking for confirmation." Because "acceptance prompting" might be hard to understand
- Make trustall/acceptall warning more verbose. - Trustall/acceptall warning will show if you start chat with -a or --acceptall or --trust-all-tools - /trust and /untrust takes an unlimited amount of tools at a time - /trust and /untrust will display an error if you specify a tool name that does not exist
I wonder if we can remove that text but for the user input indicator, we can show ![all tools trusted]> initially Then for the subsequent inputs we just show !> We assume our users are smarter than us, so if they somehow figured out how to trust all tools, they should already know the risk. We just need some text indicating what ! means |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments.
We have gotten some feedback that
IMO Instead, what if we just remove |
Interesting, that means we are not communicating that properly when they run Or if confirmation dialog is too much code change, we can just add that risk disclaimer as well as the (!) and put it in a different color. Maybe we can replace ! with 🤖 or something to look not too punishing... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for now to unblock release. we can iterate on UI as we go
#1157
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.