fix(ssh): update Match condition syntax for OpenSSH 9.9p1 compatibility #1190
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix SSH integration for OpenSSH 9.9p1 compatibility
Description
This PR addresses issue #1026 where SSH connections were failing with the error "Bad Match condition" on systems running OpenSSH 9.9p1.
The root cause was identified as a syntax incompatibility in the SSH config file generated by Amazon Q Developer CLI. OpenSSH 9.9p1 enforces stricter
requirements for Match conditions, requiring explicit criteria before the exec parameter.
The fix updates the Match condition syntax in
crates/fig_integrations/src/ssh/mod.rs
:Match exec "command -v {bin_name} && {bin_name} internal generate-ssh --remote-host %h --remote-port %p --remote-username %r"
Match all exec="command -v {bin_name} && {bin_name} internal generate-ssh --remote-host %h --remote-port %p --remote-username %r"
This maintains backward compatibility with older OpenSSH versions while fixing the issue with the newer version.
Testing
cargo build --all
which completed successfullyRelated issue
Fixes #1026