Skip to content

Migrate fsx client to aws-sdk-go v2 #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

Yiyuanzzz
Copy link
Contributor

@Yiyuanzzz Yiyuanzzz commented Apr 2, 2025

Summary

Migrate FSX to aws-sdk-go-v2

Implementation details

  • Updated the FSxClient interface to use the new method signature with context.Context and variadic options for fsx.DescribeFileSystems
  • Migrate from session.Session to aws.Config per the docs.
  • Updated test assertions to align with the new SDK v2 types ([]types.FileSystem instead of []*fsx.FileSystem).
  • Replacement of aws.StringValue() to aws.ToString()

Testing

New tests cover the changes: no

Description for the changelog

Enhancement: Migrate FSX to aws-sdk-go-v2

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Yiyuanzzz Yiyuanzzz requested a review from a team as a code owner April 2, 2025 04:02
@Yiyuanzzz Yiyuanzzz changed the title [WIPSdkv2/fsx [WIP]Sdkv2/fsx Apr 2, 2025
@Yiyuanzzz Yiyuanzzz changed the title [WIP]Sdkv2/fsx [WIP]migrate fsx to v2 Apr 2, 2025
@Yiyuanzzz Yiyuanzzz changed the base branch from master to dev April 2, 2025 04:02
@Yiyuanzzz Yiyuanzzz force-pushed the sdkv2/fsx branch 2 times, most recently from 65ce57c to 9852ee9 Compare April 2, 2025 06:18
@Yiyuanzzz Yiyuanzzz changed the title [WIP]migrate fsx to v2 Migrate fsx client to aws-sdk-go v2 Apr 2, 2025
TheanLim

This comment was marked as duplicate.

TheanLim
TheanLim previously approved these changes Apr 7, 2025
prateekchaudhry
prateekchaudhry previously approved these changes Apr 7, 2025
@Yiyuanzzz Yiyuanzzz changed the base branch from dev to feature/sdkv2-fsx April 9, 2025 20:08
@Yiyuanzzz Yiyuanzzz changed the base branch from feature/sdkv2-fsx to dev April 9, 2025 20:15
@Yiyuanzzz Yiyuanzzz changed the base branch from dev to feature/sdkv2-fsx April 9, 2025 20:33
@Yiyuanzzz Yiyuanzzz merged commit 3222bfd into aws:feature/sdkv2-fsx Apr 14, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants