Add OnPrem test back #635
Merged
Add OnPrem test back #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duhminick
reviewed
Dec 13, 2025
|
|
||
| # SELinux test setup (if enabled) | ||
| var.is_selinux_test ? [ | ||
| "sudo yum install amazon-cloudwatch-agent -y", |
Contributor
There was a problem hiding this comment.
This is kind of weird to me: why are we installing the agent from yum when we should be installing a local build?
Contributor
Author
There was a problem hiding this comment.
This is to revert the previous change which I think it's wrong 54bceae#diff-7bd8f9f5e97c6da06e4bf19f9af808f0b39d6034c15800262f0f6300d7fced06R129-R135
Contributor
There was a problem hiding this comment.
created an internal ticket to track fixing this
movence
force-pushed
the
hsookim/onprem
branch
from
2c6ab52 to
2effcbf
Compare
the-mann
approved these changes
Dec 16, 2025
| { | ||
| "os": "debian-12", | ||
| "username": "admin", | ||
| "instanceType": "c6g.large", |
Contributor
There was a problem hiding this comment.
why is this using c6g.large but the ubuntu is using t3a.medium?
duhminick
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PR: aws/amazon-cloudwatch-agent#1962
Description of the issue
OnPrem integ test had been removed due to broken validation
Description of changes
Update linux terraform file to support
is_onpremflag with extra setupsLicense
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
https://github.com/aws/amazon-cloudwatch-agent/actions/runs/20178604561