Sort the examples in the CF template #795
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code previously produced CF code from a listing of files from the fs.readdirSync function. The problem is that the order of the files returned by fs.readdirSync is determined by the underlying filesystem implementation, and thus changes from one filesystem to the next. This was causing the template code to be produced with elements in a different order from one developer to the next. This did not result in any functional difference (or bug) in the template, but it did cause the template tests to fail because the the snapshot verification expects a fixed order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code previously produced CF code from a listing of files from the
fs.readdirSync()function. The problem is that the order of the files returned byfs.readdirSync()is determined by the underlying filesystem implementation, and thus changes from one filesystem to the next.This was causing the template code to be produced with elements in a different order from one developer to the next. This did not result in any functional difference (or bug) in the template, but it did cause the template tests to fail because the the snapshot verification expects a fixed order.
Description of changes:
source/templates/examples/extensions/js_lambda_hooks,source/templates/examples/extensions/py_lambda_hooks,source/templates/examples/examples/js, andsource/templates/examples/examples/pyBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.